[Warnings] Replace deprecated is_fx_tracing with is_fx_tracing_symbolic_tracing#2463
[Warnings] Replace deprecated is_fx_tracing with is_fx_tracing_symbolic_tracing#2463
Conversation
…_tracing PyTorch deprecated is_fx_tracing() in favor of more specific functions. Updated to use is_fx_tracing_symbolic_tracing() for FX symbolic tracing. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a PyTorch deprecation warning by updating the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses a PyTorch deprecation warning by replacing the is_fx_tracing() function with is_fx_tracing_symbolic_tracing(). The changes in src/llmcompressor/pipelines/sequential/transformers_helpers.py correctly update the import and the function call. This is the appropriate replacement given the context of FX symbolic tracing in this file. The change is minimal, targeted, and correctly resolves the deprecation issue. No issues were found in this pull request.
kylesayrs
changed the title
|
The quality checks have failed. Please run |
2 participants
Summary
is_fx_tracing()withis_fx_tracing_symbolic_tracing()intransformers_helpers.pyDetails
PyTorch deprecated
is_fx_tracing()because it returns true for bothfx.symbolic_traceandtorch.export. The new API provides separate functions:is_fx_tracing_symbolic_tracing()forfx.symbolic_tracetorch.compiler.is_compiling()fortorch.export/compileThis code specifically handles FX symbolic tracing with Proxy objects, so
is_fx_tracing_symbolic_tracing()is the correct replacement.🤖 Generated with Claude Code